normal "resolution_fit": "1" doesn't work.

"resolution_fit": "1" doesn't work. - Printable Version

+- Ventoy Forums (https://forums.ventoy.net)
+-- Forum: Ventoy Plugin —— Ventoy 插件 (https://forums.ventoy.net/forumdisplay.php?fid=3)
+--- Forum: Ventoy Plugin Forum (https://forums.ventoy.net/forumdisplay.php?fid=4)
+--- Thread: "resolution_fit": "1" doesn't work. (/showthread.php?tid=2663)

Pages: 1 2

"resolution_fit": "1" doesn't work. - Divzed - 09-11-2023

"theme_800x600" "theme_1024x768" "theme_1920x1080" - They have 3 different background images with different resolutions, but for some reason background image and theme is drawn randomly by "default_file": "0" regardless of selected resolution and "resolution_fit": "1" is ignored every time when I boot Ventoy, why?
I tried it on live system UEFI/BIOS and VirtualBox VM UEFI/BIOS, monitor resolution 1920x1080. I also tried to remove "default_file": "0", but issue still persists.

My ventoy.json:

Code:
{

    "theme": {

        "file": [

             "/ventoy/themes/theme_800x600/theme_800x600.txt",

             "/ventoy/themes/theme_1024x768/theme_1024x768.txt",

             "/ventoy/themes/theme_1920x1080/theme_1920x1080.txt"

        ],

        "default_file": "0",

        "resolution_fit": "1",

        "gfxmode": "1920x1080",

        "display_mode": "GUI",

        "serial_param": "--unit=0 --speed=9600",

        "ventoy_left": "95%",

        "ventoy_top": "1%",

        "ventoy_color": "#000000",

        "fonts": [

            "/ventoy/themes/theme_1920x1080/terminus-12.pf2",

            "/ventoy/themes/theme_1920x1080/terminus-14.pf2",

            "/ventoy/themes/theme_1920x1080/terminus-16.pf2",

            "/ventoy/themes/theme_1920x1080/DejaVuSans-48.pf2",

            "/ventoy/themes/theme_1920x1080/DejaVuSans-Regular-14.pf2"

        ]

    },

    "menu_class": [

        {

            "key": "Windows",

            "class": "Windows"

        },

        {

            "key": "windows",

            "class": "Windows"

        },

        {

            "key": "Win",

            "class": "Windows"

        },

        {

            "key": "win",

            "class": "Windows"

        },

        {

            "key": "memtest",

            "class": "MemTest86"

        },

        {

            "key": "iso",

            "class": "ISO"

        }

    ]

}

RE: "resolution_fit": "1" doesn't work. - nguyen ha thai trong - 09-11-2023

Please take a photo and post it to the forum

RE: "resolution_fit": "1" doesn't work. - nguyen ha thai trong - 09-12-2023

I don't see any errors in ventoy and your code, when you remove "default_file": "0" it means "default_file": "0" because ventoy defaults like that, setting "resolution_fit": " 1", Ventoy selects the number of themes equal to the number of themes you provide, so there is no error here.

RE: "resolution_fit": "1" doesn't work. - Divzed - 09-12-2023

(09-12-2023, 12:03 AM)nguyen ha thai trong Wrote: I don't see any errors in ventoy and your code, when you remove "default_file": "0" it means "default_file": "0" because ventoy defaults like that, setting "resolution_fit": " 1", Ventoy selects the number of themes equal to the number of themes you provide, so there is no error here.

What? Seems like you missunderstood purpose of "resolution_fit": "1" key. Please read this documentation https://www.ventoy.net/en/plugin_theme.html#vtoy_theme_res_fit
The entire point of "resolution_fit": "1" is to filter out themes with resolution that match Screen/UEFI/Ventoy resolution and automatically apply this specific theme on boot.
This is why it is required to rename theme folder or file "theme.txt" with resolution affix, e.g. XYZ_1920x1080, XYZ_1024x768, XYZ_800x600... and add their paths to ventoy.json.
For some reason "resolution_fit": "1" filters out all themes regardless of specified resolution in ventoy.json theme > file plugin. This is not how it supposed to work according to documentation.

[Image: bcJnbLb.png]

So, when I boot in Screen/UEFI/Ventoy resolution 1920x1080, theme XYZ_1920x1080 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 1024x768, theme XYZ_1024x768 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 800x600, theme XYZ_800x600 should be automatically selected on boot and the other themes should be ignored.

RE: "resolution_fit": "1" doesn't work. - nguyen ha thai trong - 09-12-2023

So does ventoy work like you mentioned here?
So, when I boot in Screen/UEFI/Ventoy resolution 1920x1080, theme XYZ_1920x1080 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 1024x768, theme XYZ_1024x768 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 800x600, theme XYZ_800x600 should be automatically selected on boot and the other themes should be ignored.

RE: "resolution_fit": "1" doesn't work. - Divzed - 09-12-2023

(09-12-2023, 05:33 PM)nguyen ha thai trong Wrote: So does ventoy work like you mentioned here?
So, when I boot in Screen/UEFI/Ventoy resolution 1920x1080, theme XYZ_1920x1080 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 1024x768, theme XYZ_1024x768 should be automatically selected on boot and the other themes should be ignored.
When I boot in Screen/UEFI/Ventoy resolution 800x600, theme XYZ_800x600 should be automatically selected on boot and the other themes should be ignored.

No. This is the reason why I created this thread and used auxiliary verb "should" in previous response and even posted screenshots that prove it.

RE: "resolution_fit": "1" doesn't work. - nguyen ha thai trong - 09-12-2023

When you boot in Screen/UEFI/Ventoy resolution 1024x768, which theme is selected?

RE: "resolution_fit": "1" doesn't work. - Divzed - 09-12-2023

(09-12-2023, 06:13 PM)nguyen ha thai trong Wrote: When you boot in Screen/UEFI/Ventoy resolution 1024x768, which theme is selected?

On every boot, theme is randomly selected from 3 of them that are listed in ventoy.json > theme > file [].

RE: "resolution_fit": "1" doesn't work. - nguyen ha thai trong - 09-12-2023

Can you post the theme and ventoy.json so I can test? Is the error in ventoy1.0.95 or is it from the previous version?

Have you tried changing current resolution with F5 Tools -> Resolution Configuration menu? Because according to the documentation :

RE: "resolution_fit": "1" doesn't work. - Divzed - 09-12-2023

(09-12-2023, 06:40 PM)nguyen ha thai trong Wrote: Can you post the theme and ventoy.json so I can test? Is the error in ventoy1.0.95 or is it from the previous version?

Have you tried changing current resolution with F5 Tools -> Resolution Configuration menu? Because according to the documentation :

Ventoy version - 1.0.95

Yes, I tried to change resolution with F5 Tools -> Resolution Configuration, after resolution change this way, theme remains the same as it was randomly drawn at boot.